Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add spell checker info to contrib guide #2489

Closed
wants to merge 17 commits into from

Conversation

StackScribe
Copy link
Contributor

Summary

Adds information about using the spell checker to the Contributing Guide

Fixes #2462

Checks

  • My PR fulfills the Definition of Done of the corresponding issue and not more (or parts if the issue is separated
    into multiple PRs)
  • I used descriptive commit messages to help reviewers understand my thought process
  • I signed off all my commits according to the Developer Certificate of Origin (DCO)(
    see Contribution Guide)
  • My PR title is formatted according to the semantic PR conventions described in
    the Contribution Guide
  • My content follows the style guidelines of this project (YAMLLint, markdown-lint)
  • I regenerated the auto-generated docs for Helm and the CRD documentation (if applicable)
  • I have performed a self-review of my content including grammar and typo errors and also checked the rendered page
    from the Netlify deploy preview
  • My changes result in all-green PR checks (first-time contributors need to ask a maintainer to approve their test runs)

StackScribe and others added 15 commits November 13, 2023 17:37
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: odubajDT <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: odubajDT <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: odubajDT <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: odubajDT <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: odubajDT <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: odubajDT <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: odubajDT <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: odubajDT <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
check-spelling run (pull_request_target) for 1107-tips

Signed-off-by: check-spelling-bot <[email protected]>
on-behalf-of: @check-spelling <[email protected]>
@StackScribe StackScribe added the documentation Improvements or additions to documentation label Nov 14, 2023
@StackScribe StackScribe added this to the 0.10 milestone Nov 14, 2023
@StackScribe StackScribe self-assigned this Nov 14, 2023
@StackScribe StackScribe requested review from a team as code owners November 14, 2023 07:20
@StackScribe StackScribe marked this pull request as draft November 14, 2023 07:20
@github-actions github-actions bot added the ops label Nov 14, 2023
Copy link

netlify bot commented Nov 14, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 57f5065
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/655426a5f8aca70008e57af2
😎 Deploy Preview https://deploy-preview-2489--keptn-lifecycle-toolkit.netlify.app/contribute/docs/spell-checker
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #2489 (57f5065) into main (97acdbf) will increase coverage by 0.10%.
Report is 8 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2489      +/-   ##
==========================================
+ Coverage   85.56%   85.66%   +0.10%     
==========================================
  Files         167      170       +3     
  Lines       10217    10479     +262     
==========================================
+ Hits         8742     8977     +235     
- Misses       1200     1226      +26     
- Partials      275      276       +1     

see 15 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 67.43% <ø> (ø)
component-tests 56.52% <ø> (+0.56%) ⬆️
lifecycle-operator 84.48% <ø> (ø)
metrics-operator 87.75% <ø> (+0.07%) ⬆️
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@mowies mowies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR seems like it has some content from the tips and tricks PR inside 🤔

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@StackScribe
Copy link
Contributor Author

This PR has problems. It is replaced by #2504 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add info about spell checker to contrib guide
2 participants